[
https://issues.apache.org/jira/browse/MESOS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958287#comment-13958287
]
Adam B commented on MESOS-1181:
-------------------------------
Here's the current error count for the inactive_rules from Dominic's review
(minus build/include_alpha which has 0):
build/header_guard - 450
build/include - 6
build/include_order - 1443
build/include_what_you_use - 187
build/namespaces - 201
build/storage_class - 14
legal/copyright - 209
readability/braces - 9
readability/casting - 165
readability/check - 40
readability/function - 16
readability/namespace - 606
readability/streams - 62
readability/todo - 5
runtime/arrays - 3
runtime/explicit - 64
runtime/int - 140
runtime/printf - 7
runtime/references - 41
runtime/string - 13
runtime/threadsafe_fn - 9
whitespace/blank_line - 4
whitespace/braces - 3723
whitespace/comments - 1559
whitespace/empty_loop_body - 44
whitespace/end_of_line - 6
whitespace/indent - 723
whitespace/line_length - 111
whitespace/newline - 2
whitespace/operators - 5
whitespace/parens - 552
whitespace/semicolon - 1
> Improve cpplint rule coverage
> -----------------------------
>
> Key: MESOS-1181
> URL: https://issues.apache.org/jira/browse/MESOS-1181
> Project: Mesos
> Issue Type: Improvement
> Reporter: Adam B
> Assignee: Adam B
> Priority: Minor
> Labels: lint, style
>
> ReviewBot is checking our patches' style for us, and we can check it
> ourselves with support/mesos-style.py, but there are only a few rules enabled
> right now. I plan to enable more rules, fixing lint errors as needed. I'd
> also like to add new style rules for things like single/double line spacing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
