----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19967/#review39375 -----------------------------------------------------------
3rdparty/libprocess/include/process/pid.hpp <https://reviews.apache.org/r/19967/#comment71764> Alternatively, we could try to teach cpplint.py to ignore this warning if '!' follows 'operator', to handle operator overloading cases like this. - Adam B On April 2, 2014, 4:54 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19967/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 4:54 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1181 > https://issues.apache.org/jira/browse/MESOS-1181 > > > Repository: mesos-git > > > Description > ------- > > Enabled whitespace/operators rule for cpplint, which covers the following: > 'Missing spaces around =' > # You should always have whitespace around binary operators. > # Check <= and >= first to avoid false positives with < and >, then > # check non-include lines for spacing around < and >. > # We allow no-spaces around << when used like this: 10<<20, but > # not otherwise (particularly, not when used as streams) > # Also ignore using ns::operator<<; > 'Missing spaces around <' > 'Missing spaces around >' > # There shouldn't be space around unary operators > > > Diffs > ----- > > 3rdparty/libprocess/include/process/pid.hpp fbd512f > src/common/type_utils.hpp 784a808 > support/mesos-style.py edd41f926d6df30513f8fa6c928960e6495af70a > > Diff: https://reviews.apache.org/r/19967/diff/ > > > Testing > ------- > > Ran mesos-style.py over entire source base with whitespace/operators enabled. > > > Thanks, > > Adam B > >
