> On April 1, 2014, 4:57 p.m., Benjamin Hindman wrote: > > src/master/master.hpp, line 390 > > <https://reviews.apache.org/r/19006/diff/4/?file=537795#file537795line390> > > > > What about the use of activated/deactivated here? Can we have > > 'connected', 'disconnected', and 'removed' where 'removed' will eventually > > be removed (no pun intended) once the registrar is fully in place?
Filed new JIRA MESOS-1188 to "Rename slaves/frameworks.activated/deactivated". We can discuss naming suggestions there. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19006/#review39219 ----------------------------------------------------------- On March 26, 2014, 9:41 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19006/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 9:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Moved code to disconnect a checkpointing slave out of Master::exited() and > into a new disconnect(Slave), to be re-used by slave authentication code. > Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a > ShutdownMessage and calls removeSlave(). This avoids confusion with > deactivateFramework, which is more analagous to disconnect(Slave). > > > Diffs > ----- > > src/master/master.hpp b6b9983 > src/master/master.cpp 5d0ddb0 > > Diff: https://reviews.apache.org/r/19006/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
