> On April 3, 2014, 7:45 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 141-144 > > <https://reviews.apache.org/r/19259/diff/3/?file=548212#file548212line141> > > > > Can we comment that we're doing this before we fork because it might > > not be async-signal safe? > > > > Also, how about we simplify this back to as it was before and just do: > > > > internal::Envp envp(environment.get(map<string, string>()));
I entirely missed the Option::get default override - lovely! - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19259/#review39464 ----------------------------------------------------------- On April 3, 2014, 10:46 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19259/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 10:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Ian Downes. > > > Bugs: MESOS-1102 > https://issues.apache.org/jira/browse/MESOS-1102 > > > Repository: mesos-git > > > Description > ------- > > Adds the ability to process::subprocess to run a function (lambda) within the > child context, after fork and before exec. > > NOTE: Such lambda must not contain any async unsafe code. For details on > async safety, see POSIX.1-2004 on async-signal-safe functions, also > referenced in the signal man-pages: > http://man7.org/linux/man-pages/man7/signal.7.html. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp 6c51c0b > 3rdparty/libprocess/src/subprocess.cpp e09c808 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp 9413ecc > > Diff: https://reviews.apache.org/r/19259/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
