> On April 2, 2014, 3:55 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, lines 482-483 > > <https://reviews.apache.org/r/19901/diff/1/?file=544947#file544947line482> > > > > I think we can simplify this sentence; the container can be killed for > > various reasons - register timeout, in error states and so on. I don't > > think we need to capture this here :)
I copied this from the original definition of slave::Containerizer::Termination. If it made sense there, I thought it might make sense here as well. Let me know if I should drop this or if you still preferred simplification. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19901/#review39266 ----------------------------------------------------------- On April 2, 2014, 5:20 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19901/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 5:20 a.m.) > > > Review request for mesos, Ian Downes, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Replaced slave::Containerizer::Termination with a protobuf message called > Termination for allowing it to be reused in ExternalContainerizer, gaining a > serializable Termination message. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7f > src/slave/containerizer/containerizer.hpp d9ae326 > src/slave/containerizer/mesos_containerizer.hpp ee1fd30 > src/slave/containerizer/mesos_containerizer.cpp c819c97 > src/slave/slave.hpp 15e23ce > src/slave/slave.cpp a356f5f > src/tests/containerizer.hpp a9f1531 > src/tests/containerizer.cpp bfb9341 > > Diff: https://reviews.apache.org/r/19901/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
