----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/#review39592 -----------------------------------------------------------
Ship it! LGTM! src/slave/containerizer/cgroups_launcher.hpp <https://reviews.apache.org/r/20025/#comment72033> maybe mention namespace as well? - Chi Zhang On April 4, 2014, 8:33 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20025/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 8:33 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, > and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > This is a rename only; there are no code changes but this facilitates a > follow on review which will modify the launcher to support both Linux cgroups > and Linux namespaces. > > > Diffs > ----- > > src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af > src/slave/containerizer/cgroups_launcher.hpp > db61107141f60dd13cfa13278a7daab16f0d108c > src/slave/containerizer/cgroups_launcher.cpp > 39f0e4c3baaed3403da160ba63dada4a53d9af09 > src/slave/containerizer/containerizer.cpp > 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c > src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13 > > Diff: https://reviews.apache.org/r/20025/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >