----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20026/#review39582 -----------------------------------------------------------
Please add some tests to exercise the new code path. src/slave/containerizer/isolator.hpp <https://reviews.apache.org/r/20026/#comment72331> Please adjust the comments here. src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20026/#comment72332> Do you need to setup the environment variables from CommandInfo? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20026/#comment72333> Do you need to say something about the child script execution. For example, when it will be executed? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20026/#comment72006> s/executoro/executor/ src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20026/#comment72330> Seems that 'fork' here now has isolate + fetch + exec. You may wanna do one of the following: 1) rename 'fork' to '_launch' as it is now really a continuation of 'launch'. 2) keep the existing flow in 'launch' and use partial bind for 'inChild'. I personally prefer the second option:) - Jie Yu On April 7, 2014, 8:23 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20026/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 8:23 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, > and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > Modified Isolator API so optional commands are returned from prepare and run > in the child before exec'ing the executor. > > Modified LinuxLauncher to use clone() to optionally run a process in one or > more different namespaces. > > > Diffs > ----- > > src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af > src/slave/containerizer/cgroups_launcher.hpp > db61107141f60dd13cfa13278a7daab16f0d108c > src/slave/containerizer/cgroups_launcher.cpp > 39f0e4c3baaed3403da160ba63dada4a53d9af09 > src/slave/containerizer/containerizer.cpp > 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c > src/slave/containerizer/isolator.hpp > d410c73c5feac9cbd391b7a2b66141aa9aa75423 > src/slave/containerizer/isolator.cpp > f7935b3f20530e9c5558a636f40d69371a963102 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 49cc5bc2407e99c81e0a8eaff11cffd1136b019c > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 11665dbe88e3920fd9d8a2259987611d49e85462 > src/slave/containerizer/isolators/cgroups/mem.hpp > ffd81b330202ad6eff48940b762e3f7105008b4b > src/slave/containerizer/isolators/cgroups/mem.cpp > 9e9c55e37f499898196b61cc586cb0e49feabf56 > src/slave/containerizer/isolators/posix.hpp > 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524 > src/slave/containerizer/launcher.hpp > dee526f254d56a7a974a70522cd0ca059814fb6d > src/slave/containerizer/launcher.cpp > c83327b2f13f0511c8e4e0e9902bc6a1e1328283 > src/slave/containerizer/mesos_containerizer.hpp > ee1fd3010b4a178a6abcbd813af5eba4d564be00 > src/slave/containerizer/mesos_containerizer.cpp > c819c97d96d232a1de3c1ed2fc848bebf66981f7 > src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13 > > Diff: https://reviews.apache.org/r/20026/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
