----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/#review39815 -----------------------------------------------------------
Ship it! Feel free to commit this after addressing the comments so that we can iterate on this! As a follow up, per my comments on the other review, it would be nice to also know how long an individual operation takes on a full registry. src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72452> Maybe a TODO that we want to use LogStorage when available to exercise what we're using in production. src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72453> Add a comment about why you needed the second test frame? src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72454> We should test up to 50,000 as I promised that to some folks. ;) src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72455> Do you want to add a using clause for vector? src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72456> Is it possible to use size_t instead of int for the parameterization? src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72457> Can you put result right above the loop, below the watch starting? src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72458> Probably we can lower the Hours(1) now, right? ;) Ditto below. src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72459> Comment as to why we chose to shuffle? src/tests/registrar_tests.cpp <https://reviews.apache.org/r/19761/#comment72460> Ditto. - Ben Mahler On April 4, 2014, 6:33 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19761/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 6:33 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1155 > https://issues.apache.org/jira/browse/MESOS-1155 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/registrar_tests.cpp 67c26aad8185f1328a7eb05c993ed14d47dc0664 > > Diff: https://reviews.apache.org/r/19761/diff/ > > > Testing > ------- > > mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” > –gtest_also_run_disabled_tests > > > Thanks, > > Jiang Yan Xu > >
