----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20178/#review39954 -----------------------------------------------------------
Patch looks great! Reviews applied: [20178] All tests passed. - Mesos ReviewBot On April 9, 2014, 8:51 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20178/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 8:51 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1160 > https://issues.apache.org/jira/browse/MESOS-1160 > > > Repository: mesos-git > > > Description > ------- > > Usage of implicit flattening for creation of Future objects from Try objects. > Only the checkDiskUsage method was modified to use this implicit flattening. > I tried to find out all the occurrences of "Future<Try<" in the repository to > determine all the places where the flattening would be useful. Apparently, > only the checkDiskUsage method used such objects. However, there might be > instances of implicit creation of Future<Try<T>> objects in the codebase > which can be fixed only after a more detailed inspection. > > > Diffs > ----- > > src/slave/slave.hpp 15e23ce > src/slave/slave.cpp a356f5f > > Diff: https://reviews.apache.org/r/20178/diff/ > > > Testing > ------- > > No new tests written. All previous tests succeed which implies that the > checkDiskUsage method still renders similar functionality after flattening. > > > Thanks, > > Ritwik Yadav > >
