----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20070/#review39971 -----------------------------------------------------------
Ship it! src/usage/main.cpp <https://reviews.apache.org/r/20070/#comment72752> I don't think you need stringify because of the cast operator in JSON::Protobuf(). src/usage/usage.hpp <https://reviews.apache.org/r/20070/#comment72753> s/!pstree.isSome()/pstree.isError()/ src/usage/usage.hpp <https://reviews.apache.org/r/20070/#comment72757> I understand this is mimicking the earlier behavior, but how about returning an Error instead? Currently it is hard to distinguish the case between non-existent pid and user calling this method without setting mem and cpus. AFAICT, the only way to distinguish is that in the former case we return ResourceStatistics that doesn't have timestamp set. - Vinod Kone On April 7, 2014, 1:59 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20070/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 1:59 a.m.) > > > Review request for mesos, Ian Downes, Till Toenshoff, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af > src/slave/containerizer/isolators/posix.hpp > 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524 > src/usage/main.cpp PRE-CREATION > src/usage/usage.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20070/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
