----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18381/#review40266 -----------------------------------------------------------
Patch looks great! Reviews applied: [20302, 20301, 18381] All tests passed. - Mesos ReviewBot On April 14, 2014, 4:09 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18381/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 4:09 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Added authentication support for slaves. > Fixes MESOS-804. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7f > src/master/flags.hpp 024f86d > src/master/master.hpp fef59c9 > src/master/master.cpp 3c3c989 > src/sasl/authenticatee.hpp 42a4eba > src/slave/flags.hpp d5c54c0 > src/slave/slave.hpp 08f6005 > src/slave/slave.cpp cddb241 > src/tests/authentication_tests.cpp 127c5e6 > src/tests/mesos.cpp a9844e4 > src/tests/slave_recovery_tests.cpp 72b6d42 > > Diff: https://reviews.apache.org/r/18381/diff/ > > > Testing > ------- > > make check; manually tested flatfile slave authentication success/failure. > Added new slave authentication unit tests in authentication_tests.cpp. > > > Thanks, > > Adam B > >
