----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20404/#review40540 -----------------------------------------------------------
Patch looks great! Reviews applied: [20404] All tests passed. - Mesos ReviewBot On April 16, 2014, 5:19 a.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20404/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 5:19 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Fix lock issue in src/common/lock.cpp > > The Lock class used as a lock itself to protect other resources, > however, its internal locked variable is changed without lock > protection in the unlock member function. > > To protect the locked variable, it should change it before release the > mutex. So the Lock not only protect the others but itself internal state > too. > > Review: https://reviews.apache.org/r/20404 > > > Diffs > ----- > > src/common/lock.cpp 11c8e8c50d806271c36c2ec20633acf06447c37f > > Diff: https://reviews.apache.org/r/20404/diff/ > > > Testing > ------- > > make check passed. > > > Thanks, > > Chengwei Yang > >
