> On April 16, 2014, 1:49 a.m., Vinod Kone wrote: > > src/sasl/common.hpp, line 32 > > <https://reviews.apache.org/r/20301/diff/1/?file=555776#file555776line32> > > > > put this under credentials namespace. > > Adam B wrote: > Do you want it in mesos::internal::sasl::credentials or in > mesos::internal::credentials? > It really has nothing sasl-specific in it, so I'm leaning towards the > latter, in which case should I move it to src/credentials/credentials.hpp?
sgtm. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20301/#review40487 ----------------------------------------------------------- On April 14, 2014, 5:01 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20301/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 5:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Moved reading of credentials file out of master.cpp and into sasl/common.hpp > for reuse by slave authentication. > > > Diffs > ----- > > src/master/master.cpp 3c3c989 > src/sasl/common.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20301/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
