> On April 18, 2014, 2:29 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 81 > > <https://reviews.apache.org/r/20018/diff/5/?file=562379#file562379line81> > > > > Can you describe why you want to do this? We can just make local http > > requests to get the JSON, right?
expanded comment. > On April 18, 2014, 2:29 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, lines 116-120 > > <https://reviews.apache.org/r/20018/diff/5/?file=562379#file562379line116> > > > > Calling get() will crash if the option is none, are there some hidden > > semantics here that ensure these are SOME? it's subtle - the statistics being none indicates the statistics object was created with an empty timeseries. the outer statistics option will already be none in this case as the metric was created without a history window. So if the outer statistics option is some, the inner ones should be some also. is the preference to avoid a crash in this case by adding a conditional or to add a CHECK to show the explicit relationship? - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/#review40814 ----------------------------------------------------------- On April 18, 2014, 2:47 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20018/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 2:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metric.hpp > 6c48357a39598b5b0a324ed664366467c0518ebd > 3rdparty/libprocess/include/process/metrics/metrics.hpp > c20bb639e8ef79de63f0d0d56c2ea40a15a1f995 > 3rdparty/libprocess/src/metrics/metrics.cpp > 391295aea91e837bb856a40ef51d1c33d44371d8 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > abe1588c931b45a09294812974788aa74de44dd4 > > Diff: https://reviews.apache.org/r/20018/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
