> On April 23, 2014, 5:21 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 140 > > <https://reviews.apache.org/r/20615/diff/1/?file=565651#file565651line140> > > > > Why do we need to do this only in this test and the next one? > > > > Isn't the metrics process initialized with libprocess initialization? > > > > Have we understood what the root cause of the bug (also, please attach > > the bug id) is? > > Dominic Hamon wrote: > metrics process is initialized the first time a metric is added to the > system. all the other tests add a counter - this explicitly tries to get the > endpoint without metrics to check it starts empty. > > > i couldn't find a ticket so i opened one.
That is indeed unfortunate, any chance we can ensure it's initialized when libprocess is initialized? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20615/#review41159 ----------------------------------------------------------- On April 23, 2014, 5:28 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20615/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1235 > https://issues.apache.org/jira/browse/MESOS-1235 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 6f3795b33b92dd0621867e274649f8b9667ba538 > > Diff: https://reviews.apache.org/r/20615/diff/ > > > Testing > ------- > > build/3rdparty/libprocess/tests --gtest_filter='Metrics.Snapshot*' > --gtest_repeat=-1 --gtest_shuffle --gtest_break_on_failure > > > Thanks, > > Dominic Hamon > >
