----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20581/#review41214 -----------------------------------------------------------
src/master/registrar.cpp <https://reviews.apache.org/r/20581/#comment74649> Is it necessary to invert the order here? Maybe it's just simpler to keep the same order? src/master/registrar.cpp <https://reviews.apache.org/r/20581/#comment74656> If Gauge is passed the RegistrarProcess, could it not store it and provide it's own function for getting the queue size? (Much like what we did for Master::Http). - Ben Mahler On April 23, 2014, 8:48 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20581/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 8:48 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added Timers for state store/fetch and a Gauge to track the length of the > operations queue. > > > Diffs > ----- > > src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 > > Diff: https://reviews.apache.org/r/20581/diff/ > > > Testing > ------- > > local build + mesos-local.sh + manual inspection. > make check. > > > Thanks, > > Dominic Hamon > >
