> On April 24, 2014, 5:55 p.m., Benjamin Hindman wrote: > > include/mesos/containerizer/containerizer.proto, line 40 > > <https://reviews.apache.org/r/20668/diff/1/?file=567777#file567777line40> > > > > For some external containerizer programs the Mesos libexec directory > > will also be valuable for other calls, such as Usage (to find mesos-usage) > > so rather than adding this to every protobuf let's make the > > ExternalContainerizer put this in the environment as > > MESOS_LIBEXEC_DIRECTORY just as it does for things like > > MESOS_DEFAULT_CONTAINER_IMAGE.
Hah, that is exactly what I had in mind and wanted to discuss with you :) .... awesome, yes, let's do that. > On April 24, 2014, 5:55 p.m., Benjamin Hindman wrote: > > include/mesos/containerizer/containerizer.proto, lines 32-33 > > <https://reviews.apache.org/r/20668/diff/1/?file=567777#file567777line32> > > > > I think we want s/task/task_info/ and s/executor/executor_info/. Aye - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20668/#review41332 ----------------------------------------------------------- On April 24, 2014, 5:22 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20668/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 5:22 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Updated Launch message to reflect latest commits on the TaskInfo related > containerizer Launch call/s. Renamed the Launch message attribute > "mesos_executor_path" to "mesos_libexec_directory" which will now hold the > libexec-path instead of the mesos-executor path directly - thus being usable > for other mesos provided executables (e.g. mesos-usage). > > Added Destroy, Wait and Usage messages to allow extending those messages in > the future, where needed. > > > Diffs > ----- > > include/mesos/containerizer/containerizer.proto 6ecd82e > > Diff: https://reviews.apache.org/r/20668/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
