-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20817/
-----------------------------------------------------------
(Updated April 29, 2014, 12:36 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Jie Yu, and
Vinod Kone.
Changes
-------
Addressed BenM and Jie's comments.
Repository: mesos-git
Description
-------
The Freezer tries to converge to the "FROZEN" state by repeatedly (every
100 ms) writing "FROZEN" to the freezer.state control file (up to a
configurable timeout). It assumes there are two possible reasons why a
process does not get frozen during an attempt:
1. It was in the middle of being forked and did not receive the signal;
it will receive it at the next attempt.
2. It is in uninterruptable sleep ("D" state). Normally, this is from
device I/O or paging and is shortlived, in which case it'll be frozen on
retry. However, processes can get stuck in "D" state, either because of
a device issue, incorrect OOM handling, or kernel bugs. Under this
scenario the correct behavior is to fail after a timeout (defaults to 60
seconds).
Freezer functions have been namespaced under cgroups::freezer.
Diffs (updated)
-----
3rdparty/libprocess/include/process/statistics.hpp
929fb8d544fe83edadbc856efca14177ae30315e
3rdparty/libprocess/src/metrics/metrics.cpp
bb36c729532ce9a2ffad51d5b25e95355a78abad
3rdparty/libprocess/src/tests/metrics_tests.cpp
459982b224d6005af22edd9f0172e1feae3f8add
3rdparty/libprocess/src/tests/statistics_tests.cpp
0e4960a4e2e807ee9f3f6d83cdbfa6b563352760
configure.ac 27b2ac87c68a48781bcc3e98f7cdab16b38e7a02
src/Makefile.am cb95f7cec411b3fab7f83958f798fec30e0e9454
src/examples/python/test_containerizer.py
7bebfee708e6c616b1358207ba912a4f38d609d2
src/linux/cgroups.hpp 5a5735721fb9f051eee661edb08d1cdaa163d0f3
src/linux/cgroups.cpp 8202c282f580d027a60ded2081962e96e4860f60
src/slave/containerizer/containerizer.cpp
374a778e62321dfb57c2ad19a3614154596f4b9f
src/slave/containerizer/linux_launcher.hpp
8f96c6996e0d06c37c29233f5e02f002db743dfb
src/slave/containerizer/linux_launcher.cpp
530e0bd64d71bad761a2eab3d6e2f2179a167b4b
src/slave/containerizer/mesos_containerizer.hpp
9be1b67f6afc63f275474b091a2df55d38cf032f
src/slave/containerizer/mesos_containerizer.cpp
2c64f2d70251b154fb023c152a2dea4575c409a4
src/tests/cgroups_tests.cpp 6ba9de622953e158feadaa9950618b0b13c9e832
src/tests/cluster.hpp 906300d65e1c3cbc288474ef9f616d5e97bb2348
src/tests/isolator_tests.cpp b0eff5721b6ea4dcee8ff3748a2a11ade809e30e
src/tests/slave_recovery_tests.cpp 919d108828ae80775032562a629184116541d074
Diff: https://reviews.apache.org/r/20817/diff/
Testing
-------
make check # Linux
Thanks,
Ian Downes
