----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20885/#review41853 -----------------------------------------------------------
You can disregard the ReviewBot failure in ExternalContainerizerTest. That is a known bug that is actively being worked on. Your change looks pretty good to me. I just have a few style comments for starters. 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp <https://reviews.apache.org/r/20885/#comment75490> __STOUT_BASE64_HPP__ 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp <https://reviews.apache.org/r/20885/#comment75491> namespace stout 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp <https://reviews.apache.org/r/20885/#comment75492> Irregular comment style. I think we usually prefer // comments over /*block*/ comments 3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp <https://reviews.apache.org/r/20885/#comment75493> Please add the standard copyright/license comment block at the top of each file. - Adam B On April 30, 2014, 2 a.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20885/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 2 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1131 > https://issues.apache.org/jira/browse/MESOS-1131 > > > Repository: mesos-git > > > Description > ------- > > 1st Phase following Ben's comments on https://reviews.apache.org/r/19575/ > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 7faa562 > 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20885/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
