----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20935/#review41906 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On May 1, 2014, 4:23 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20935/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 4:23 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We are hitting the "Unqualified lookup in templates" issue in stout interval > set: > http://clang.llvm.org/compatibility.html#dep_lookup > > And looks like this is a boost bug: > 1) boost/icl/concept/interval.hpp:621 defines a template that uses > 'lower_less_equal' > 2) boost/icl/concept/interval.hpp:877 'lower_less_equal' is defined here > > Since lower_less_equal does not contain any class type, the compiler may or > may not choose to reject the program according to the C++ standard :( > Clearly, gcc-4.8 rejects the program and gcc-4.4 does not. > > I am using a workaround here to bypass the problem. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp df01e13 > > Diff: https://reviews.apache.org/r/20935/diff/ > > > Testing > ------- > > make check > > Tested using: > 1) gcc-4.4 on Linux > 2) gcc-4.8 on Mac > > > Thanks, > > Jie Yu > >
