----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20850/ -----------------------------------------------------------
(Updated May 1, 2014, 11:09 a.m.) Review request for mesos. Repository: mesos-git Description ------- Rename 'minloglevel' flag in 'logging_level' in order to be consistent with the existing flags. Rename 'getMinLogLevel' function in 'getLogSeverity' to be more suggestive for what it does. Disallow configuring FATAL logging because it's a special case and it involves too many changes across the entire source code. Create validation for the 'logging_level' flag in order to notify the user if it had entered an unsupported value. Update the documentation for 'logging_level' flag, with the values it can take. Diffs (updated) ----- src/logging/flags.hpp 457feeeb7ca7ececf3c4e69189800ecb370053e6 src/logging/logging.hpp 39c2934f733e5c058f62b5497f31f7a7057bb4c7 src/logging/logging.cpp 176e49a6a2aef13be44ff910144c7321c942345a src/master/master.cpp f205dca43f10697862e3fd3f435f1127a9d0aecb src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4 src/webui/master/static/js/controllers.js 4b8487e0c285f892ad352993c81637f38df1429f Diff: https://reviews.apache.org/r/20850/diff/ Testing ------- Thanks, Alexandra Sava
