----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20875/#review41926 -----------------------------------------------------------
Ship it! Much cleaner! - Ian Downes On April 29, 2014, 8:51 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20875/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 8:51 p.m.) > > > Review request for mesos, Ian Downes, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1256 > https://issues.apache.org/jira/browse/MESOS-1256 > > > Repository: mesos-git > > > Description > ------- > > Introduces MesosContainerizer::create instead of Containerizer::create. Would > need to do the same thing for ExternalContainerizer and then should be able > to plug in ExternalContainerizer for all the containerizer type parameterized > tests. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp > 374a778e62321dfb57c2ad19a3614154596f4b9f > src/slave/containerizer/mesos_containerizer.hpp > a5eb247c8f932f201563f330360be2139cc8123a > src/slave/containerizer/mesos_containerizer.cpp > df57e5443d0e3a94588464d83822ed5e3e9f88ea > src/tests/slave_recovery_tests.cpp cd28c8b586fbd4fbcdeab408391c5bf341d42d0c > src/tests/slave_tests.cpp 07ce882fce9a6d3c0e77f51f58b17d0ee365e088 > > Diff: https://reviews.apache.org/r/20875/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
