----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20956/#review41930 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/envp.hpp <https://reviews.apache.org/r/20956/#comment75579> why not just include os.hpp for os::environment()? 3rdparty/libprocess/3rdparty/stout/include/stout/os/envp.hpp <https://reviews.apache.org/r/20956/#comment75580> maybe rename it to ExecEnv? - Dominic Hamon On May 1, 2014, 10:17 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20956/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 10:17 a.m.) > > > Review request for mesos, Bruno Mahé, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Add Envp (from Subprocess) to stout and added a copy constructor. This will > be used in a subsequent review for safely setting a child environment using > execle (Subprocess is not used). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > aa1d0a59cadefe28723b8f4b73ffae8469759270 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > 3rdparty/libprocess/3rdparty/stout/include/stout/os/envp.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20956/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
