-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20963/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

This isolator only creates the perf_event cgroup and places the executor into 
the cgroup; no performance statistics are gathered/exported.

NOTE: The recover() as implemented is "non-strict"; it will happily recover 
containers even if they don't have a perf_event cgroup present. This permits 
restarting the slave to add this isolator. Existing containers will not be 
isolated. New containers will be isolated.


Diffs
-----

  src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 
  src/slave/containerizer/containerizer.cpp 
374a778e62321dfb57c2ad19a3614154596f4b9f 
  src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION 
  src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/20963/diff/


Testing
-------

Manually tested.

Our current testing code does not easily permit testing different combinations 
of isolators for the MesosContainerizer.


Thanks,

Ian Downes

Reply via email to