----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20923/#review41963 -----------------------------------------------------------
Looks great! 3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20923/#comment75631> We can remove this now, right? :) 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20923/#comment75637> It looks like this test is asserting that the timer names are valid ("_ms" and "_us" suffixes). I'm wondering why we couldn't just use Metric::name() to check the names in the existing Timer tests? (As opposed to adding this new test that makes http requests?) - Ben Mahler On April 30, 2014, 10:54 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20923/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 10:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/timer.hpp > 26f997c0c5e034dab88cf59bb641754fec7b5abe > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 75f1f0e35fdb1ec707785d1ebb903af99551bdaa > > Diff: https://reviews.apache.org/r/20923/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
