----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20932/#review41980 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/20932/#comment75693> Missing a space here? src/master/master.cpp <https://reviews.apache.org/r/20932/#comment75689> Do you want to '' quote the message, or just say: LOG(WARNING) << "Shutting down slave " << *slave << " with message '" << message << "'"; src/master/master.cpp <https://reviews.apache.org/r/20932/#comment75694> Missing a space here? - Ben Mahler On May 1, 2014, 12:39 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20932/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 12:39 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1182 and MESOS-1270 > https://issues.apache.org/jira/browse/MESOS-1182 > https://issues.apache.org/jira/browse/MESOS-1270 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 333e37ccd5746c5026740cfcb816499cea61a545 > src/master/master.cpp f205dca43f10697862e3fd3f435f1127a9d0aecb > > Diff: https://reviews.apache.org/r/20932/diff/ > > > Testing > ------- > > make check (there were some unrelated flaky/broken tests for which there are > already tickets filed) > > > Thanks, > > Vinod Kone > >
