----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21005/#review42086 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On May 2, 2014, 1:57 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21005/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 1:57 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Updated mesos to satisfy whitespace/indent and enabled the cpplint rule. > Modified cpplint.py to check that access keywords are NOT indented. > > > Diffs > ----- > > src/log/coordinator.cpp 271fe89 > src/log/recover.cpp 7c0566a > src/python/native/mesos_executor_driver_impl.cpp a2f7607 > src/python/native/mesos_scheduler_driver_impl.cpp ff5c749 > src/slave/state.cpp 2889245 > src/tests/master_tests.cpp 65779a7 > src/tests/slave_recovery_tests.cpp 21b1345 > support/cpplint.patch 63b5ae9 > support/cpplint.py 2ad644e > support/mesos-style.py 4649edb > > Diff: https://reviews.apache.org/r/21005/diff/ > > > Testing > ------- > > make check > With whitespace/line_length enabled, $ ./support/mesos-style.py > Checking 424 files using filter > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/tab,+whitespace/todo > Total errors found: 0 > > (Download the manual diff if you want the full review, because > whitespace-only changes don't show up in RB.) > > > Thanks, > > Adam B > >
