> On May 3, 2014, 2:47 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/configure.ac, line 182 > > <https://reviews.apache.org/r/20983/diff/1/?file=573032#file573032line182> > > > > Please wrap within 80 characters (this should now be caught with > > mesos-style.py): > > > > AM_CONDITIONAL([WITH_BUNDLED_HTTP_PARSER], > > [test "x$with_bundled_http_parser" = "xyes"]) > > Adam B wrote: > Unfortunately, cpplint (used by mesos-style.py) does not check .ac files, > just .cpp/hpp/c/h files. We'd have to do a bit more work to get some > selective rules to also apply to .ac files, Makefiles, python or bash > scripts, etc.
Ahh, thanks for letting us know Adam. How much more work? Seems like it might be worth it! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20983/#review42083 ----------------------------------------------------------- On May 1, 2014, 9:15 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20983/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 9:15 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1175 > https://issues.apache.org/jira/browse/MESOS-1175 > > > Repository: mesos-git > > > Description > ------- > > Updates libprocess configure check for http-parser to build against system > dependencies outlined in MESOS-1071 > + fixes libprocess local 'make check' which was broken > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 8ccf0ef > 3rdparty/libprocess/Makefile.am 8990f38 > 3rdparty/libprocess/configure.ac fc5e2ad > > Diff: https://reviews.apache.org/r/20983/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
