----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review42167 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto <https://reviews.apache.org/r/18730/#comment75890> How about a comment explaining that an 'Entity' captures both "subjects" and "objects" in the normal ACL verbiage. include/mesos/mesos.proto <https://reviews.apache.org/r/18730/#comment75891> RUN_COMMANDS_AS? src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment75892> Any reason not to take the individual ACLs? For example: virtual process::Future<bool> authorize( const ACL::DO_GET_ON& get) = 0; virtual process::Future<bool> authorize( const ACL::DO_PUT_ON& put) = 0; The advantage here is that we can check multiple subjects/objects at the same time. src/tests/master_contender_detector_tests.cpp <https://reviews.apache.org/r/18730/#comment75893> How about explicitly calling out namespace here? - Benjamin Hindman On May 1, 2014, 6:58 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 6:58 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto e48e50aae248bd9d5289dbaa36753be53b2e592a > src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 > src/authorizer/authorizer.hpp PRE-CREATION > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/master_contender_detector_tests.cpp > 42051bfc7c698e2e80cfe23686ee11ef722b679e > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
