> On May 5, 2014, 11:32 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp, line 59 > > <https://reviews.apache.org/r/21013/diff/4/?file=574733#file574733line59> > > > > Trailing space.
Same issue here, there is no trailing space in my patch. > On May 5, 2014, 11:32 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp, line 69 > > <https://reviews.apache.org/r/21013/diff/4/?file=574733#file574733line69> > > > > Why psymbol? Is it an abbreviation for something? If so, let's expand > > or drop the 'p' > > > > Also, instead of a return argument. How about using Try<void*> instead > > and return it? > > > > symbolname should be camel case too right? > > > > Lastly, "sym" is an abbreviation. should it be "symbol" or "loadSymbol" > > ? changed everything except the call semantics which I'd argue are more correct. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21013/#review42210 ----------------------------------------------------------- On May 5, 2014, 3:22 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21013/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 3:22 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1224 > https://issues.apache.org/jira/browse/MESOS-1224 > > > Repository: mesos-git > > > Description > ------- > > Addition of DynamicLibrary class to stout, to enable future plugins inside of > mesos. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 980146b > 3rdparty/libprocess/3rdparty/stout/Makefile.am aa1d0a5 > 3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > PRE-CREATION > 3rdparty/libprocess/configure.ac 0c7cc6d > > Diff: https://reviews.apache.org/r/21013/diff/ > > > Testing > ------- > > New test has been added and ran 'make check' around Mac and Linux > > > Thanks, > > Timothy St. Clair > >
