----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review42343 -----------------------------------------------------------
src/launcher/fetcher.cpp <https://reviews.apache.org/r/20674/#comment76128> Some one mentioned this on the MesosJenkins GitHub yesterday. This check for executable no longer works because a new letter "[XN]" is appended to the end of the URI. This should be: s/token.substr(pos + 1)/token.substr(pos + 1, 1)/ - Vinod Kone On April 25, 2014, 6:28 a.m., Tom Arnfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20674/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 6:28 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ian Downes, > Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-1241 > https://issues.apache.org/jira/browse/MESOS-1241 > > > Repository: mesos-git > > > Description > ------- > > This is a patch that includes a new `extract` boolean value on > CommandInfo.URI to toggle the auto-extraction of compressed archives when > shipping URIs with an executor or task. > > It's worth noting that this changes the behaviour of the MESOS_EXECUTOR_URI > environment variable used. I've added some comments which outlines the > expected format, instead of (e.g) hdfs://foobar/testing.tar.gz+0 (1 > signifying it's not executable) there is now an extra flag on the end (X or > N) defining whether to auto-extract or not, resulting in > hdfs://foobar/testing.tar.gz+0X by default. > > > Diffs > ----- > > include/mesos/mesos.proto d7fe068 > src/launcher/fetcher.cpp 98ebc2e > src/slave/containerizer/mesos_containerizer.cpp f5df979 > src/tests/containerizer_tests.cpp 6c48146 > > Diff: https://reviews.apache.org/r/20674/diff/ > > > Testing > ------- > > - Tested with a single-slave mesos cluster (Mac OSX 10.9) > - Verified `make check` after adding extra unit tests > > > Thanks, > > Tom Arnfeld > >
