----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21277/#review42643 -----------------------------------------------------------
Ship it! Nice to see this! What's the reason we don't just transmit the raw protobuf string? Is this to make it easier to implement a custom fetcher (without the need to have mesos.proto)? - Tom Arnfeld On May 9, 2014, 7:05 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21277/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 7:05 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld. > > > Bugs: MESOS-1248 > https://issues.apache.org/jira/browse/MESOS-1248 > > > Repository: mesos-git > > > Description > ------- > > See summary (and bug). > > > Diffs > ----- > > src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 > src/slave/fetcher.hpp PRE-CREATION > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21277/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
