----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21269/#review42763 -----------------------------------------------------------
src/linux/routing/utils.hpp <https://reviews.apache.org/r/21269/#comment76650> "our functionalities" needs to be expanded. do you mean the network isolator for network monitoring? if yes, will this "check()" be done in the network isolator code? also, a "routing::check()" in the library util seems a bit out of place. should this be defined in network isolator instead like we did with cgroup nested functionality? src/tests/routing_tests.cpp <https://reviews.apache.org/r/21269/#comment76652> Instead of failing the test, can we disable the test at runtime similar to what we did for cgroups tests? Also, do *all* these tests need the capabilities checked in check()? - Vinod Kone On May 9, 2014, 10:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21269/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 10:27 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > See summary. We need this to check the capability of the underlying libnl > library. > > > Diffs > ----- > > src/Makefile.am f461a15 > src/linux/routing/utils.hpp PRE-CREATION > src/linux/routing/utils.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21269/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
