----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21130/ -----------------------------------------------------------
(Updated May 12, 2014, 11:18 p.m.) Review request for mesos and Niklas Nielsen. Changes ------- Fixed typo in comment. Repository: mesos-git Description ------- Updates 'recover' implementation within the ExternalContainerizer to forward the call to the ECP. Recovery invocation steps for the ExternalContainerizer: 1st: EC will invoke “recover" on the ECP. This is supposed to signal to the ECP that it should try to recover its internal states, predominantly all previously active ContainerIDs. There is no explicit parameter delivered alongside this command, and no result expected other than a proper exit status. 2nd: EC will invoke “containers” on the ECP, asking for a list of active containers (as e.g. internally recovered in step 1). 3rd: EC will now try to recover its internal state, mostly the sandbox information (Directory and User) as initially delivered by the “launch” invocation. NOTE: The test_containerizer.py implementation of 'recover' is incomplete, it merely poses as a mock-up. NOTE: This does *not* fix MESOS-1257. A complete test_containerizer C++ implementation is upcoming to fix these notes. Diffs (updated) ----- src/examples/python/test_containerizer.py 7bebfee src/slave/containerizer/external_containerizer.hpp 8fdf097 src/slave/containerizer/external_containerizer.cpp e51ac66 Diff: https://reviews.apache.org/r/21130/diff/ Testing ------- make (test is currently inactive) Thanks, Till Toenshoff
