----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21360/#review42815 -----------------------------------------------------------
support/mesos-style.py <https://reviews.apache.org/r/21360/#comment76735> How about taking the list of file names to run the linter against as command line args to mesos-style.py?. I think thats more flexible and lets users feed it whatever files they want. e.g., 'git diff --name-only | xargs ./support/mesos-style.py' - Vinod Kone On May 13, 2014, 3:25 a.m., Steven Phung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21360/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 3:25 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1349 > https://issues.apache.org/jira/browse/MESOS-1349 > > > Repository: mesos-git > > > Description > ------- > > Previously run_lint was being invoked a large subset of the source tree which > was inefficient. With this change it enables mesos-style.py to potentially be > used as a pre-commit hook. > > git diff is used to determine which staged files that have been added or > removed. The intersection between the staged files and all lint candidates > is computed and sent to cpplint. The return value of the mesos-style.py > script is the result of the cpplint process exit or 0 if there the > intersection is empty. > > > Diffs > ----- > > support/mesos-style.py bd7dcdb > > Diff: https://reviews.apache.org/r/21360/diff/ > > > Testing > ------- > > ./support/mesos-style.py > > > Thanks, > > Steven Phung > >
