[
https://issues.apache.org/jira/browse/MESOS-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996713#comment-13996713
]
Yan Xu commented on MESOS-1338:
-------------------------------
I am adding metrics for all message types in Master:
{code}
// Messages from schedulers.
process::metrics::Counter framework_registration_messages;
process::metrics::Counter framework_reregistration_messages;
process::metrics::Counter framework_unregistration_messages;
process::metrics::Counter framework_deactivation_messages;
process::metrics::Counter kill_task_messages;
process::metrics::Counter resource_request_messages;
process::metrics::Counter task_launch_messages;
process::metrics::Counter offer_revival_messages;
process::metrics::Counter task_reconciliation_messages;
process::metrics::Counter authentication_messages;
process::metrics::Counter framework_to_executor_messages;
// Messages from slaves.
process::metrics::Counter slave_registration_messages;
process::metrics::Counter slave_reregistration_messages;
process::metrics::Counter slave_unregistration_messages;
process::metrics::Counter status_update_messages;
process::metrics::Counter executor_exit_messages;
{code}
Following the pattern of a few existing message counters, I am using noun
phrases to name the variables for Messages with names in verb phrases:
[ReviveOffersMessage|https://github.com/apache/mesos/blob/5764fa54a3e01a502f40669cc9965439dffe76f9/src/messages/messages.proto#L170]
-> offer_revival_messages.
Personally, I am not sure whether this improves readability to I'd follow the
convention here.
Thoughts on naming?
> Add global counters for each message type on Master
> ---------------------------------------------------
>
> Key: MESOS-1338
> URL: https://issues.apache.org/jira/browse/MESOS-1338
> Project: Mesos
> Issue Type: Sub-task
> Reporter: Yan Xu
> Assignee: Yan Xu
> Fix For: 0.19.0
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
