----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21166/#review42988 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/21166/#comment76979> (1) To keep this simple for now, I would suggest we only add metrics for the "grandfathered" scalar resources: cpus, mem, disk This lets us manage the lifetime of the Gauges inside 'Metrics' and '~Metrics'. (2) Why do these need to be allocated on the heap? src/master/master.hpp <https://reviews.apache.org/r/21166/#comment76980> This is not thread safe! You need to use 'defer' to access the members of a Process. - Ben Mahler On May 13, 2014, 5:52 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21166/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 5:52 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1132 > https://issues.apache.org/jira/browse/MESOS-1132 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 923552e3c7f9942d6be7a0446b44e40f53c11433 > src/master/master.cpp 569995c2eaf758f5171c4e0d082d4e519a143025 > > Diff: https://reviews.apache.org/r/21166/diff/ > > > Testing > ------- > > make check > > ran local instance and manually verified resource statistics show up and > match stats.json. > > > Thanks, > > Dominic Hamon > >
