> On May 14, 2014, 11:32 a.m., Dominic Hamon wrote: > > To ensure developers actually use this, should it just be in post-review > > instead? > > Adam B wrote: > Not all developers actually use post-review(s) either. Putting it in make > check (MESOS-1205) would ensure that more developers run the style check > before submitting reviews. I see the git commit hook less for developers (who > may create diffs without committing locally) and more as a last-minute check > for the committers to make sure no new style errors slip in. > > Vinod Kone wrote: > Good points gentlemen. I agree putting it in 'post-reviews' is a good > idea though that shouldn't preclude us from enabling people to use it as a > git pre-commit hook. It is much easier to correct mistakes before you commit > than having to rebase/edit while submitting reviews. And as Adam mentioned, > having a git pre-commit hook would also automatically check for style issues > when committers do "apply-review". And, yes, adding it to make check is also > a good idea. But lets keep this review about pre-commit hook. > >
SGTM to have ALL the things! - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21439/#review42994 ----------------------------------------------------------- On May 14, 2014, 10:43 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21439/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 10:43 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Dominic > Hamon. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/mesos-developers-guide.md d195bded640dd4f55672b75ad1cc5f0ea4aa9fd7 > support/hooks/pre-commit PRE-CREATION > > Diff: https://reviews.apache.org/r/21439/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Vinod Kone > >
