> On May 16, 2014, 8:53 p.m., Dominic Hamon wrote: > > src/master/master.cpp, line 946 > > <https://reviews.apache.org/r/21501/diff/1/?file=582775#file582775line946> > > > > this should probably be in a separate patch.
There is no semantic change here, just took the opportunity to add a log line. I don't think that is worth a new patch. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21501/#review43262 ----------------------------------------------------------- On May 15, 2014, 10:43 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21501/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 10:43 p.m.) > > > Review request for mesos, Dominic Hamon and Jiang Yan Xu. > > > Bugs: MESOS-1358 > https://issues.apache.org/jira/browse/MESOS-1358 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/http.cpp f54c841d003d7a4d2eda5e93405afa358707f4e0 > src/master/master.hpp 25d9e837198ffed60c445e21de4ba0cba49106f0 > src/master/master.cpp 63b6cdc9634608ac730de7194fb8ed0baadb9a77 > src/webui/master/static/home.html ea9444ae966d3fb68e749780c075eea037b2909c > > Diff: https://reviews.apache.org/r/21501/diff/ > > > Testing > ------- > > Tested locally w/ and w/o an elected master. Web UI handles electedTime being > None correctly. > > > Thanks, > > Vinod Kone > >
