----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21565/#review43402 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77499> New file that you're missing from this diff? 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77498> Maybe grab std::map along with std::string while you're at it? 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77497> Not yours, but add a space after foreachpair please. 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77492> How about ASSERT_SOME(flags.load(values))? 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77491> Maybe ASSERT_SOME_EQ since how do you know 'json.get()' will not fail? 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77496> I'm guessing TemporaryDirectoryTest defined in the missing utils.hpp? 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77495> What's 'tmpdir'? Perhaps it's exposed in the mysterious TemporaryDirectoryTest? We didn't expose 'tmpdir' in Mesos but instead used os::getcwd() for stuff like this. 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/21565/#comment77493> ASSERT_SOME's here like above too. - Benjamin Hindman On May 17, 2014, 1:13 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21565/ > ----------------------------------------------------------- > > (Updated May 17, 2014, 1:13 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1344 > https://issues.apache.org/jira/browse/MESOS-1344 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp > a781f14aec9dc5b6350d8e5452a7131cbb891595 > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48 > > Diff: https://reviews.apache.org/r/21565/diff/ > > > Testing > ------- > > stout make check > > > Thanks, > > Vinod Kone > >
