> On May 19, 2014, 9:55 p.m., Till Toenshoff wrote: > > src/tests/environment.cpp, line 137 > > <https://reviews.apache.org/r/21664/diff/2/?file=584703#file584703line137> > > > > Couldn't you drop those outer brackets?
Sry, did not mean to raise this as an issue as I am unsure about our style for these cases. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21664/#review43425 ----------------------------------------------------------- On May 19, 2014, 9:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21664/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 9:49 p.m.) > > > Review request for mesos, Dominic Hamon and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > See summary. cgroups::enabled() is not available on OSX. > > > Diffs > ----- > > src/tests/environment.cpp 3f4eaad > src/tests/slave_recovery_tests.cpp 11a1430 > > Diff: https://reviews.apache.org/r/21664/diff/ > > > Testing > ------- > > make check on OSX > make check and sudo make check on Linux > > > Thanks, > > Jie Yu > >
