> On May 20, 2014, 6:13 p.m., Jay Buffington wrote: > > .gitignore-template, line 21 > > <https://reviews.apache.org/r/21718/diff/3/?file=585304#file585304line21> > > > > Shouldn't this line live in > > https://github.com/3rdparty/libprocess/blob/master/.gitignore ? > > > > It's not 100% clear to me how 3rdparty modules are pulled in. They're > > not git submodules, right? They are actually copied into the repo?
Sorry I just updated - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21718/#review43509 ----------------------------------------------------------- On May 20, 2014, 6:13 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21718/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 6:13 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-654 > https://issues.apache.org/jira/browse/MESOS-654 > > > Repository: mesos-git > > > Description > ------- > > Adding missing files to gitignore template > > > Diffs > ----- > > .gitignore-template f7654a4 > > Diff: https://reviews.apache.org/r/21718/diff/ > > > Testing > ------- > > > Thanks, > > Isabel Jimenez > >
