----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21777/#review43637 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/21777/#comment77916> What is the exact warning that you are seeing in clang 3.4? Does it fail compilation? Also, would it be better to overload the copy constructor of Result for Unreachable? - Vinod Kone On May 21, 2014, 4:24 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21777/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 4:24 p.m.) > > > Review request for mesos, Till Toenshoff and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > see summary > > Without the explicit conversion some compilers find the conversion from > Unreachable() to Result<T>() ambiguous. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 94d8b4c7fcf83946e2f9dd0f3e746889599ca174 > > Diff: https://reviews.apache.org/r/21777/diff/ > > > Testing > ------- > > able to build on clang 3.4 > > > Thanks, > > Dominic Hamon > >
