----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19545/#review43662 -----------------------------------------------------------
Can you also add a test that verifies that system stats end up in metrics endpoint? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/19545/#comment77951> ASSERT_SOME(responseJSON); 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/19545/#comment77952> Where is 'responseJSON' declared? How did this even compile!? - Vinod Kone On May 15, 2014, 6:15 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19545/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 6:15 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1146 > https://issues.apache.org/jira/browse/MESOS-1146 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/system.hpp > fbd1eaa1de44eb419cef4c78efd6d138eabc7b44 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > > Diff: https://reviews.apache.org/r/19545/diff/ > > > Testing > ------- > > make check and manually checked /system/stats.json against /metrics > > > Thanks, > > Dominic Hamon > >
