----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21787/#review43672 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/21787/#comment77960> log both expected and actual principals here. src/master/master.cpp <https://reviews.apache.org/r/21787/#comment77961> log the authenticating principal. src/master/master.cpp <https://reviews.apache.org/r/21787/#comment77968> Maybe this should be a WARNING to nudge people to set the principal? Also, how about the scheduler driver automatically setting FramworkInfo.principal when authentication is being used? The one issue is that, as we move to native clients, we dont want too much logic in the driver. src/master/master.cpp <https://reviews.apache.org/r/21787/#comment77966> ditto. log the principals. src/master/master.cpp <https://reviews.apache.org/r/21787/#comment77967> ditto. log the authentication principal. src/master/master.cpp <https://reviews.apache.org/r/21787/#comment77969> Also log the principal. LOG(INFO) << "Successfully authenticated principal '" << future.get() << "' at " << pid; src/tests/authentication_tests.cpp <https://reviews.apache.org/r/21787/#comment77971> Can you pull this into its own test? src/tests/mesos.hpp <https://reviews.apache.org/r/21787/#comment77970> Can we get the principal from DEFAULT_CREDENTIAL here? - Vinod Kone On May 21, 2014, 10:01 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21787/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 10:01 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1373 > https://issues.apache.org/jira/browse/MESOS-1373 > > > Repository: mesos-git > > > Description > ------- > > This will be used to 'Add "per-framework-principal" counters for all messages > from a scheduler on Master': https://issues.apache.org/jira/browse/MESOS-1339 > > > Diffs > ----- > > include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 > src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f > src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 > src/tests/authentication_tests.cpp b60e595216c2b854adf048002a0d88b548e1d92e > src/tests/mesos.hpp a1a7d7991c4cdb7a994218602fe4e5d76c056456 > > Diff: https://reviews.apache.org/r/21787/diff/ > > > Testing > ------- > > Added tests. Make check. > > > Thanks, > > Jiang Yan Xu > >
