> On May 22, 2014, 8:08 p.m., Niklas Nielsen wrote: > > Modulo explaining the reason for this special case in a comment or two
Have a look at the rephrased comments please and let me know if that is explaining things for you and everybody else a bit better. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21681/#review43765 ----------------------------------------------------------- On May 23, 2014, 3:20 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21681/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 3:20 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > When 'wait' was terminated by 'destroy', it is getting SIGKILLed (see > unwait). We need to test for that specific case and setup the appropriate > Termination message accordingly as it can not get delivered by the external > containerizer program itself. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp f9811c4 > > Diff: https://reviews.apache.org/r/21681/diff/ > > > Testing > ------- > > make check (using the upcoming EC test suite) > > > Thanks, > > Till Toenshoff > >
