----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22160/#review44736 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79234> This is true for all namespaces *except* PID namespaces where setns() means that *children* of the re-associated thread will be in the specified namespace. 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79238> Why are we always using syscalls directly and not setns(2) when it's available? When would __NR_setns be defined and not SYS_setns? 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79245> Can you comment on which versions of glibc are old? 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79236> What happens on 32 bit systems? 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79240> Add a comment on why this is ordered like this? 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79244> What does it mean to associate a *thread* to another pid's namespace? This implies different threads in a process could be in different namespaces so which one do you associate to? Perhaps we only support associating all threads of the process to the target namespace. 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp <https://reviews.apache.org/r/22160/#comment79242> What about checking os::exists(pid) first to see if the pid is running? 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp <https://reviews.apache.org/r/22160/#comment79243> Why not test the other namespaces - NEWMNT, NEWPID and NEWUSER? - Ian Downes On June 2, 2014, 4:20 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22160/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 4:20 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1450 > https://issues.apache.org/jira/browse/MESOS-1450 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 1474bbc > 3rdparty/libprocess/3rdparty/stout/Makefile.am 8f32a66 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22160/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
