----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22223/#review44738 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/22223/#comment79246> How about pushing this into slave model? src/master/http.cpp <https://reviews.apache.org/r/22223/#comment79247> How about just calling them "unknown_frameworks" or maybe "disconnected_frameworks"? but disconnected is an overloaded term because a framework might be disconnected even when the master doesn't failover. src/tests/master_tests.cpp <https://reviews.apache.org/r/22223/#comment79254> No need to explicitly create and pass default flags. src/tests/master_tests.cpp <https://reviews.apache.org/r/22223/#comment79255> kill flags. src/tests/master_tests.cpp <https://reviews.apache.org/r/22223/#comment79260> You probably want to advance the clock here so that the framework re-registers immediately. otherwise, it might take upto a second slowing down this test. src/tests/master_tests.cpp <https://reviews.apache.org/r/22223/#comment79261> nice test! - Vinod Kone On June 3, 2014, 11:58 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22223/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 11:58 p.m.) > > > Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This is a patch to add *orphan_tasks* and *not_yet_reregistered_frameworks" > fields in the state.json. So that users can get more information about what's > going on when master failover happens. > > For the WebUI part, I think that will have Ross to have a look at this later. > > Thanks! > > > Diffs > ----- > > src/master/http.cpp b565dc6 > src/tests/master_tests.cpp 34df121 > > Diff: https://reviews.apache.org/r/22223/diff/ > > > Testing > ------- > > Added MasterTest.OrphanTasks to test: > 1, Before the framework re-registers with the master: > Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] > field. > That frameworks will appear in the ["not_yet_reregistered_frameworks"] > field. > 2, After the framework re-registers with the master: > There will be no more orphan tasks and not-yet-reregistered frameworks. > > > Thanks, > > Yifan Gu > >
