----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22310/#review44930 -----------------------------------------------------------
Ship it! src/linux/routing/filter/internal.hpp <https://reviews.apache.org/r/22310/#comment79520> So it's not considered an error to attempt to attach it to a non u32? src/linux/routing/filter/internal.hpp <https://reviews.apache.org/r/22310/#comment79521> Is it okay to drop this TODO? - Ian Downes On June 6, 2014, 10:13 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22310/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 10:13 a.m.) > > > Review request for mesos, Ian Downes, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/routing/filter/action.hpp 8cc6594 > src/linux/routing/filter/internal.hpp cd3279a > src/linux/routing/filter/ip.hpp 8f46ee5 > src/linux/routing/filter/ip.cpp 86dbf35 > > Diff: https://reviews.apache.org/r/22310/diff/ > > > Testing > ------- > > make check > sudo make check > > Also, tested with the un-submitted network isolator. > > > Thanks, > > Jie Yu > >
