----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21316/#review45079 -----------------------------------------------------------
Bad patch! Reviews applied: [21316] Failed command: ./support/mesos-style.py Error: Checking 471 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/slave/containerizer/mesos_fetcher.cpp:68: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/slave/containerizer/mesos_containerizer.cpp:649: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/tests/containerizer_tests.cpp:89: Lines should be <= 80 characters long [whitespace/line_length] [2] src/tests/fetcher_tests.cpp:181: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/tests/fetcher_tests.cpp:247: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/tests/fetcher_tests.cpp:259: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] src/tests/fetcher_tests.cpp:269: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] Total errors found: 7 - Mesos ReviewBot On June 9, 2014, 3:17 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21316/ > ----------------------------------------------------------- > > (Updated June 9, 2014, 3:17 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-336 > https://issues.apache.org/jira/browse/MESOS-336 > > > Repository: mesos-git > > > Description > ------- > > The first cut at fetcher caching. See MESOS-336 JIRA for explanation for this > approach: keep the cache info in the MesosContainerizerProcess in the save, > leverage actor single-threadedness to deal with concurrency issues without > head ache. > > Features so far: > - If URI flag "fetched_externally" (default: false) is set, the fetcher does > what it did in Mesos 0.18 and before. > - If URI flag "cached" (default: false) is not set, the fetcher also fetches > every time as in Mesos 0.18 and before. > - If URI flag "cached" is set, the UIR is only fetched once and all > subsequent fetch attempts copy from the cache file. > - URIs are cached separately per framework (ID). > - Recovery is implemented by simply wiping the entire cache. > - GC for cache files. Global flag sets lifetime after last use. Default is 1 > hour. > > Potential future features: > - symlinks instead of copying > - extraction directly from URI, without cache file > - combine that with symlinks > - Refreshing, explicit cache invalidation > - ... > > > Diffs > ----- > > include/mesos/mesos.proto 62f69d2 > include/mesos/scheduler.hpp d224945 > src/Makefile.am 4a3f2e1 > src/launcher/fetcher.cpp c4425eb > src/local/local.cpp 5d26aff > src/slave/constants.hpp ace4590 > src/slave/constants.cpp 51f65bb > src/slave/containerizer/mesos_containerizer.hpp 1f5908a > src/slave/containerizer/mesos_containerizer.cpp 1438024 > src/slave/containerizer/mesos_fetcher.hpp PRE-CREATION > src/slave/containerizer/mesos_fetcher.cpp PRE-CREATION > src/slave/flags.hpp 15e5b64 > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > src/tests/containerizer_tests.cpp 8ea7974 > src/tests/fetcher_tests.cpp PRE-CREATION > src/tests/slave_tests.cpp 2c8f183 > > Diff: https://reviews.apache.org/r/21316/diff/ > > > Testing > ------- > > Tests have been written, have been run successfully, and are included in the > patch. > > > Thanks, > > Bernd Mathiske > >
